Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 // finally get right encoding of page. 843 // finally get right encoding of page.
844 void UpdateEncoding(blink::WebFrame* frame, 844 void UpdateEncoding(blink::WebFrame* frame,
845 const std::string& encoding_name); 845 const std::string& encoding_name);
846 846
847 // Dispatches the current state of selection on the webpage to the browser if 847 // Dispatches the current state of selection on the webpage to the browser if
848 // it has changed. 848 // it has changed.
849 // TODO(varunjain): delete this method once we figure out how to keep 849 // TODO(varunjain): delete this method once we figure out how to keep
850 // selection handles in sync with the webpage. 850 // selection handles in sync with the webpage.
851 void SyncSelectionIfRequired(); 851 void SyncSelectionIfRequired();
852 852
853 // Sends a message and runs a nested message loop. 853 // Sends a synchronous message.
854 bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message); 854 bool SendSyncMessage(IPC::SyncMessage* message);
aelias_OOO_until_Jul13 2016/05/17 19:35:29 This declaration has no implementation nor callers
Changwan Ryu 2016/05/19 00:44:56 Done.
855 855
856 bool RunJavaScriptMessage(JavaScriptMessageType type, 856 bool RunJavaScriptMessage(JavaScriptMessageType type,
857 const base::string16& message, 857 const base::string16& message,
858 const base::string16& default_value, 858 const base::string16& default_value,
859 const GURL& frame_url, 859 const GURL& frame_url,
860 base::string16* result); 860 base::string16* result);
861 861
862 // Loads the appropriate error page for the specified failure into the frame. 862 // Loads the appropriate error page for the specified failure into the frame.
863 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request, 863 void LoadNavigationErrorPage(const blink::WebURLRequest& failed_request,
864 const blink::WebURLError& error, 864 const blink::WebURLError& error,
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 FrameBlameContext* blame_context_; // Not owned. 1205 FrameBlameContext* blame_context_; // Not owned.
1206 1206
1207 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1207 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1208 1208
1209 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1209 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1210 }; 1210 };
1211 1211
1212 } // namespace content 1212 } // namespace content
1213 1213
1214 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1214 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698