Issue 1931743002: Merge "DevTools: ConsolePanel should delegate focus() to ConsoleView." to M51 branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1931743002: Merge "DevTools: ConsolePanel should delegate focus() to ConsoleView." to M51 branch (Closed)

Created:
4 years, 7 months ago by tkent

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Merge "DevTools: ConsolePanel should delegate focus() to ConsoleView." to M51 branch ConsoleView has a special handling in focus(). Delegating defaultFocusedElement() without delegating focus() is inconsistent. BUG=602099 Review URL: https://codereview.chromium.org/1909423002 Cr-Commit-Position: refs/heads/master@{#389295} (cherry picked from commit 80d0fa58f8b0277244ffab1702692fa96f6d9386) Committed: https://chromium.googlesource.com/chromium/src/+/7e01e4e7339b3c93fef757eaad7b00277b3a0d75

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

tkent

4 years, 7 months ago (2016-04-28 03:15:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e01e4e7339b3c93fef757eaad7b00277b3a0d75.