Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1909423002: DevTools: ConsolePanel should delegate focus() to ConsoleView. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: ConsolePanel should delegate focus() to ConsoleView. ConsoleView has a special handling in focus(). Delegating defaultFocusedElement() without delegating focus() is inconsistent. BUG=602099 Committed: https://crrev.com/80d0fa58f8b0277244ffab1702692fa96f6d9386 Cr-Commit-Position: refs/heads/master@{#389295}

Patch Set 1 #

Patch Set 2 : Add @override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
lushnikov@, would you review this please? This is a follow-up of https://codereview.chromium.org/1877233002
4 years, 8 months ago (2016-04-22 14:49:49 UTC) #2
lushnikov
lgtm, thanks!
4 years, 8 months ago (2016-04-22 17:47:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909423002/20001
4 years, 8 months ago (2016-04-22 23:16:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 23:21:46 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:23:24 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80d0fa58f8b0277244ffab1702692fa96f6d9386
Cr-Commit-Position: refs/heads/master@{#389295}

Powered by Google App Engine
This is Rietveld 408576698