Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1931573003: [compiler] Avoid using CompilationInfoWithZone. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Avoid using CompilationInfoWithZone. This is a preparatory change to only use the class in question when allocating a CompilationInfo on the C-heap for a compilation job. As a next step we will make CompilationInfoWithZone disappear and make the CompilationJob be the one C-heap allocated object. R=bmeurer@chromium.org Committed: https://crrev.com/0b9b6c51ce6b1da203d15d79629df9b428cb562e Cr-Commit-Position: refs/heads/master@{#35848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/compiler.cc View 3 chunks +9 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-04-28 08:31:48 UTC) #1
Benedikt Meurer
Awesome! LGTM.
4 years, 7 months ago (2016-04-28 08:35:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931573003/1
4 years, 7 months ago (2016-04-28 09:12:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 09:15:02 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b9b6c51ce6b1da203d15d79629df9b428cb562e
Cr-Commit-Position: refs/heads/master@{#35848}

Powered by Google App Engine
This is Rietveld 408576698