tools/android/loading: Force to use of simple cache on desktop.

tools/android/loading: Force to use of simple cache on desktop.

Before on desktop, the cache backend type of the HTTP cache was
choosen by the SimpleCacheTrial on field trial. This can cause
issues with sandwich were the cache backend type might change
between runs.

This CL override the cache backend type to use in Chrome on
Desktop to not have to handle the two backend types in the cache
archive processing.

BUG=582080
Committed: https://crrev.com/0e6c8e0d72463672af06ecd6a634e6d9e5078927
Cr-Commit-Position: refs/heads/master@{#390352}

[gabadie, 2016-04-27 15:53:08]

gabadie@chromium.org changed reviewers:
+ mattcary@chromium.org, pasko@chromium.org

[gabadie, 2016-04-27 15:53:08]

Hey Egor,

This CL force the use of simple cache on desktop as we discussed offline. Adding
mattcary@ on the review since this code path is also on the code path of the
collecting trace bots used for Clovis.

PTAL.

[pasko, 2016-04-27 16:07:45]

lgtm

[mattcary, 2016-04-28 09:20:25]

lgtm

https://codereview.chromium.org/1931523002/diff/1/tools/android/loading/contr...
File tools/android/loading/controller.py (right):

https://codereview.chromium.org/1931523002/diff/1/tools/android/loading/contr...
tools/android/loading/controller.py:321: # TODO(gabadie): Should we do a
SetSimpleCacheBackend(True/False)?
Unless there's going to be a reason to switch between the cache backends, I
support keeping the API simpler and just do what you've done here to make the
simple backend the default. So I think you can remove the TODO.

(The other meta-point is if there's too many TODOs sprinkled through code they
sort of become meaningless and no-one ever does anything about them. I freely
admit I'm bad at this myself... as they say in America, those who can't do,
teach)

[gabadie, 2016-04-28 11:44:07]

I have removed the TODO. Thanks for the review! Landing.

https://codereview.chromium.org/1931523002/diff/1/tools/android/loading/contr...
File tools/android/loading/controller.py (right):

https://codereview.chromium.org/1931523002/diff/1/tools/android/loading/contr...
tools/android/loading/controller.py:321: # TODO(gabadie): Should we do a
SetSimpleCacheBackend(True/False)?
On 2016/04/28 09:20:25, mattcary wrote:
> Unless there's going to be a reason to switch between the cache backends, I
> support keeping the API simpler and just do what you've done here to make the
> simple backend the default. So I think you can remove the TODO.
Done.
> 
> (The other meta-point is if there's too many TODOs sprinkled through code they
> sort of become meaningless and no-one ever does anything about them. I freely
> admit I'm bad at this myself... as they say in America, those who can't do,
> teach)
Agreed.

[gabadie, 2016-04-28 11:44:11]

The CQ bit was checked by gabadie@chromium.org

[gabadie, 2016-04-28 11:44:11]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/1931523002/#ps20001
(title: "Remove TODO")

[commit-bot: I haz the power, 2016-04-28 11:44:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931523002/20001

[commit-bot: I haz the power, 2016-04-28 12:15:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:17:38]

Patchset 2 (id:??) landed as
https://crrev.com/0e6c8e0d72463672af06ecd6a634e6d9e5078927
Cr-Commit-Position: refs/heads/master@{#390352}

[commit-bot: I haz the power, 2016-04-30 17:55:15]

Description was changed from

==========
tools/android/loading: Force to use of simple cache on desktop.

Before on desktop, the cache backend type of the HTTP cache was
choosen by the SimpleCacheTrial on field trial. This can cause
issues with sandwich were the cache backend type might change
between runs.

This CL override the cache backend type to use in Chrome on
Desktop to not have to handle the two backend types in the cache
archive processing.

BUG=582080
==========

to

==========
tools/android/loading: Force to use of simple cache on desktop.

Before on desktop, the cache backend type of the HTTP cache was
choosen by the SimpleCacheTrial on field trial. This can cause
issues with sandwich were the cache backend type might change
between runs.

This CL override the cache backend type to use in Chrome on
Desktop to not have to handle the two backend types in the cache
archive processing.

BUG=582080

Committed: https://crrev.com/0e6c8e0d72463672af06ecd6a634e6d9e5078927
Cr-Commit-Position: refs/heads/master@{#390352}
==========