tools/android/loading: Force to use of simple cache on desktop.

tools/android/loading/controller.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Controller objects that control the context in which chrome runs.
 
 This is responsible for the setup necessary for launching chrome, and for
 creating a DevToolsConnection. There are remote device and local
 desktop-specific versions.
 """
@@ skipping 299 matching lines @@
       headless: true if the chrome instance should be headless.
     """
     self._headless = headless
 
   @contextlib.contextmanager
   def OpenWithRedirection(self, stdout, stderr):
     """Override for connection context. stdout and stderr are passed to the
        child processes used to run Chrome and XVFB."""
     chrome_cmd = [OPTIONS.local_binary]
     chrome_cmd.extend(self._GetChromeArguments())
+    # Force use of simple cache.
+    # TODO(gabadie): Should we do a SetSimpleCacheBackend(True/False)?

[mattcary, 2016/04/28 09:20:25]

Unless there's going to be a reason to switch between the cache backends, I
support keeping the API simpler and just do what you've done here to make the
simple backend the default. So I think you can remove the TODO.

(The other meta-point is if there's too many TODOs sprinkled through code they
sort of become meaningless and no-one ever does anything about them. I freely
admit I'm bad at this myself... as they say in America, those who can't do,
teach)

[gabadie, 2016/04/28 11:44:07]

Done.
Agreed.

+    chrome_cmd.append('--use-simple-cache-backend=on')
     chrome_cmd.append('--user-data-dir=%s' % self._profile_dir)
     chrome_cmd.extend(['--enable-logging=stderr', '--v=1'])
     # Navigates to about:blank for couples of reasons:
     #   - To find the correct target descriptor at devtool connection;
     #   - To avoid cache and WPR pollution by the NTP.
     chrome_cmd.append('about:blank')
 
     chrome_env_override = {}
     if self._wpr_attributes:
       chrome_env_override.update(self._wpr_attributes.chrome_env_override)
@@ skipping 90 matching lines @@
         os.listdir(self._profile_dir) == []):
       # Launch chrome so that it populates the profile directory.
       with self.Open():
         pass
       print os.listdir(self._profile_dir + '/Default')
     assert os.path.isdir(self._profile_dir)
     assert os.path.isdir(os.path.dirname(self._GetCacheDirectoryPath()))
 
   def _GetCacheDirectoryPath(self):
     return os.path.join(self._profile_dir, 'Default', 'Cache')