Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1931373002: Fixed 3 final missing casts in dart:js (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 casts missed to make dart:js strong mode clean.
4 years, 7 months ago (2016-04-29 15:46:58 UTC) #2
Leaf
lgtm
4 years, 7 months ago (2016-04-29 15:49:51 UTC) #3
Jacob
4 years, 7 months ago (2016-04-29 15:50:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edd890ebedbefa862408032ad4b6418d0c409428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698