Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 1931373002: Fixed 3 final missing casts in dart:js (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/js/dart2js/js_dart2js.dart
diff --git a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
index 6fde3c644e2e76f93b7fc0667906e5bffe6f9142..4169bed09284d98d15d9616f6f3033bfa6dd444d 100644
--- a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
+++ b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
@@ -357,7 +357,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {
if (index is num && index == index.toInt()) {
_checkIndex(index);
}
- return super[index];
+ return super[index] as E;
}
void operator []=(Object index, E value) {
@@ -403,12 +403,12 @@ class JsArray<E> extends JsObject with ListMixin<E> {
E removeAt(int index) {
_checkIndex(index);
- return callMethod('splice', [index, 1])[0];
+ return callMethod('splice', [index, 1])[0] as E;
}
E removeLast() {
if (length == 0) throw new RangeError(-1);
- return callMethod('pop');
+ return callMethod('pop') as E;
}
void removeRange(int start, int end) {
« no previous file with comments | « no previous file | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698