Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1931363002: Autoplay experiment: ignore viewport visibility requirements for audio. (Closed)

Created:
4 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@autoplay-htmlmedialement
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autoplay experiment: ignore viewport visibility requirements for audio. Audio elements usually have no frame. Checking for viewport visibility requirements would be fairly similar to simply not allowing autoplay or forcing websites to switch to default controls. BUG=607918 R=liberato@chromium.org Committed: https://crrev.com/994e975fd12ed9dff7ac3c3bf4e5fd34060caf4c Cr-Commit-Position: refs/heads/master@{#391552}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/media/audio-autoplay-experiment-modes-expected.txt View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931363002/1
4 years, 7 months ago (2016-04-29 15:42:08 UTC) #2
liberato (no reviews please)
lgtm
4 years, 7 months ago (2016-04-29 16:42:38 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/221298)
4 years, 7 months ago (2016-04-29 17:00:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931363002/20001
4 years, 7 months ago (2016-05-04 14:45:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/223433)
4 years, 7 months ago (2016-05-04 15:49:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931363002/40001
4 years, 7 months ago (2016-05-04 16:01:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 17:32:51 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 17:34:04 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/994e975fd12ed9dff7ac3c3bf4e5fd34060caf4c
Cr-Commit-Position: refs/heads/master@{#391552}

Powered by Google App Engine
This is Rietveld 408576698