third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp - Issue 1931363002: Autoplay experiment: ignore viewport visibility requirements for audio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp

Issue 1931363002: Autoplay experiment: ignore viewport visibility requirements for audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autoplay-htmlmedialement

Patch Set: update tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/audio-autoplay-experiment-modes-expected.txt ('k') | third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp

diff --git a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp

index 8c54ab13ba909a26f8eee03461aaef26c51f3bff..9b3db335c44c20a1fd7e9a999e8d10b32ee895b7 100644

--- a/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp

+++ b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp

@@ -497,7 +497,7 @@ void AutoplayExperimentHelper::loadingStarted()

bool AutoplayExperimentHelper::requiresViewportVisibility() const

{

- return enabled(IfViewport) || enabled(IfPartialViewport);

+ return client().isHTMLVideoElement() && (enabled(IfViewport) || enabled(IfPartialViewport));

}

bool AutoplayExperimentHelper::isExperimentEnabled()