Fix arrow placement on menulist with padding

third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp

Index: third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp
diff --git a/third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp b/third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp
index 7191690bf02b5491a83dfc4a43c5fde14f43c4bd..b9a35ff74c9cc833120dce163242a23ebe1d0891 100644
--- a/third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp
+++ b/third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp
@@ -269,10 +269,10 @@ void ThemePainterDefault::setupMenuListArrow(const LayoutBox& box, const IntRect
         extraParams.menuList.arrowSize = rect.height() - spacingBottom - spacingTop;
     } else {
         const int arrowSize = 6;
-        const int arrowPadding = 7;
+        const int arrowPadding = 6;
         extraParams.menuList.arrowX = (box.styleRef().direction() == RTL)
             ? rect.x() + arrowPadding * box.styleRef().effectiveZoom()

[tkent, 2016/05/05 23:10:56]

We need to add borderLeft() for RTL.
Also, we need to add a RTL + border test case to menulist-appearance-basic.html.

[AdamB, 2016/05/06 04:34:42]

Done and added tests. Confirmed that we did have same issue with RTL previous
and is now resolved.

-            : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom();
+            : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom() - box.borderRight();
         extraParams.menuList.arrowSize = arrowSize * box.styleRef().effectiveZoom();
     }
     extraParams.menuList.arrowColor = box.resolveColor(CSSPropertyColor).rgb();