Fix arrow placement on menulist with padding

third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp

 /*
  * Copyright (C) 2007 Apple Inc.
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Collabora Ltd.
  * Copyright (C) 2008, 2009 Google Inc.
  * Copyright (C) 2009 Kenneth Rohde Christiansen
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 251 matching lines @@
     if (useMockTheme()) {
         // The size and position of the drop-down button is different between
         // the mock theme and the regular aura theme.
         int spacingTop = box.borderTop() + box.paddingTop();
         int spacingBottom = box.borderBottom() + box.paddingBottom();
         int spacingRight = box.borderRight() + box.paddingRight();
         extraParams.menuList.arrowX = (box.styleRef().direction() == RTL) ? rect.x() + 4 + spacingRight: right - 10 - spacingRight;
         extraParams.menuList.arrowSize = rect.height() - spacingBottom - spacingTop;
     } else {
         const int arrowSize = 6;
-        const int arrowPadding = 7;
+        const int arrowPadding = 6;
         extraParams.menuList.arrowX = (box.styleRef().direction() == RTL)
             ? rect.x() + arrowPadding * box.styleRef().effectiveZoom()

[tkent, 2016/05/05 23:10:56]

We need to add borderLeft() for RTL.
Also, we need to add a RTL + border test case to menulist-appearance-basic.html.

[AdamB, 2016/05/06 04:34:42]

Done and added tests. Confirmed that we did have same issue with RTL previous
and is now resolved.

-            : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom();
+            : right - (arrowSize + arrowPadding) * box.styleRef().effectiveZoom() - box.borderRight();
         extraParams.menuList.arrowSize = arrowSize * box.styleRef().effectiveZoom();
     }
     extraParams.menuList.arrowColor = box.resolveColor(CSSPropertyColor).rgb();
 }
 
 bool ThemePainterDefault::paintSliderTrack(const LayoutObject& o, const PaintInfo& i, const IntRect& rect)
 {
     WebThemeEngine::ExtraParams extraParams;
     WebCanvas* canvas = i.context.canvas();
     extraParams.slider.vertical = o.styleRef().appearance() == SliderVerticalPart;
@@ skipping 133 matching lines @@
         inputContentBox.y() + (inputContentBox.height() - magnifierSize + 1) / 2,
         magnifierSize, magnifierSize);
     IntRect paintingRect = convertToPaintingRect(inputLayoutBox, magnifierObject, magnifierRect, r);
 
     DEFINE_STATIC_REF(Image, magnifierImage, (Image::loadPlatformResource("searchMagnifier")));
     paintInfo.context.drawImage(magnifierImage, paintingRect);
     return false;
 }
 
 } // namespace blink