Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/autofill/core/browser/autofill_profile.h

Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_profile.h
diff --git a/components/autofill/core/browser/autofill_profile.h b/components/autofill/core/browser/autofill_profile.h
index 735cc6aac68366b95654089739f727c52ea7e4c4..7935fbbae198c6b32ed6ef13bd6c4c603f1c833d 100644
--- a/components/autofill/core/browser/autofill_profile.h
+++ b/components/autofill/core/browser/autofill_profile.h
@@ -114,8 +114,8 @@ class AutofillProfile : public AutofillDataModel {
const std::string& app_locale,
const ServerFieldTypeSet& types) const;
- // Overwrites the field data in |profile| with this Profile. Returns |true| if
- // at least one field was overwritten.
+ // Overwrites the field data in this Profile with the non-empty ones in
Mathieu 2016/04/29 12:18:43 nit: ones -> fields
sebsg 2016/04/29 15:04:49 Done.
+ // |profile|. Returns |true| if at least one field was overwritten.
Mathieu 2016/04/29 12:18:43 Should we add a note about how origin, language_co
sebsg 2016/04/29 15:04:49 Done.
bool OverwriteWith(const AutofillProfile& profile,
const std::string& app_locale);

Powered by Google App Engine
This is Rietveld 408576698