Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1930953002: V8ValueConverter::ToV8Value should not trigger setters (Closed)

Created:
3 years, 4 months ago by robwu
Modified:
3 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

V8ValueConverter::ToV8Value should not trigger setters BUG=606390 Review URL: https://codereview.chromium.org/1918793003 Cr-Commit-Position: refs/heads/master@{#390045} (cherry picked from commit b5bdf3778209179111c9f865af00940e74aa20e7) Committed: https://chromium.googlesource.com/chromium/src/+/dfadac5e2b85dfed5076434e4152aed9fc4c80ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -14 lines) Patch
M content/child/v8_value_converter_impl.cc View 4 chunks +16 lines, -12 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 4 chunks +166 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
robwu
3 years, 4 months ago (2016-04-28 14:57:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfadac5e2b85dfed5076434e4152aed9fc4c80ac.

Powered by Google App Engine
This is Rietveld 408576698