Issue 1930953002: V8ValueConverter::ToV8Value should not trigger setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1930953002: V8ValueConverter::ToV8Value should not trigger setters (Closed)

Created:
4 years, 7 months ago by robwu

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

V8ValueConverter::ToV8Value should not trigger setters BUG=606390 Review URL: https://codereview.chromium.org/1918793003 Cr-Commit-Position: refs/heads/master@{#390045} (cherry picked from commit b5bdf3778209179111c9f865af00940e74aa20e7) Committed: https://chromium.googlesource.com/chromium/src/+/dfadac5e2b85dfed5076434e4152aed9fc4c80ac

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -14 lines)			Patch
	M	content/child/v8_value_converter_impl.cc	View		4 chunks	+16 lines, -12 lines	0 comments	Download
	M	content/child/v8_value_converter_impl_unittest.cc	View		4 chunks	+166 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

robwu

4 years, 7 months ago (2016-04-28 14:57:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dfadac5e2b85dfed5076434e4152aed9fc4c80ac.