Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918793003: V8ValueConverter::ToV8Value should not trigger setters (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V8ValueConverter::ToV8Value should not trigger setters BUG=606390 Committed: https://crrev.com/b5bdf3778209179111c9f865af00940e74aa20e7 Cr-Commit-Position: refs/heads/master@{#390045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -14 lines) Patch
M content/child/v8_value_converter_impl.cc View 4 chunks +16 lines, -12 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 4 chunks +166 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robwu
4 years, 8 months ago (2016-04-25 18:08:13 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-27 10:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918793003/1
4 years, 7 months ago (2016-04-27 10:20:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 11:27:17 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 11:29:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b5bdf3778209179111c9f865af00940e74aa20e7
Cr-Commit-Position: refs/heads/master@{#390045}

Powered by Google App Engine
This is Rietveld 408576698