Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930823002: Fix assertion when parsing @namespace/@import with url(<bad-string-token>) (Closed)

Created:
4 years, 7 months ago by Timothy Loh
Modified:
4 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, alancutter (OOO until 2018)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assertion when parsing @namespace/@import with url(<bad-string-token>) This patch fixes incorrect handling of <bad-string-token> inside @namespace/@import rules. Currently a url(<bad-string-token>) is incorrectly interpreted as url(url). The added tests pass in Firefox. BUG=607095, 607500 Committed: https://crrev.com/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f Cr-Commit-Position: refs/heads/master@{#403396}

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : doctype #

Patch Set 4 : blablabla #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/import-with-bad-string.html View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/namespaces/invalid-url-in-namespace.html View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Timothy Loh
4 years, 7 months ago (2016-04-28 06:30:31 UTC) #3
rune
This fixes crbug.com/607500 as well? If so, could you add a test for it?
4 years, 7 months ago (2016-04-28 11:08:20 UTC) #5
rwlbuis
On 2016/04/28 11:08:20, rune wrote: > This fixes crbug.com/607500 as well? If so, could you ...
4 years, 7 months ago (2016-04-28 15:39:59 UTC) #6
alancutter (OOO until 2018)
lgtm
4 years, 7 months ago (2016-04-29 02:54:30 UTC) #7
Timothy Loh
On 2016/04/28 15:39:59, rwlbuis wrote: > On 2016/04/28 11:08:20, rune wrote: > > This fixes ...
4 years, 5 months ago (2016-06-30 05:03:18 UTC) #10
rune
lgtm test nit: it's most common to uppercase doctype as "<!DOCTYPE html>"
4 years, 5 months ago (2016-06-30 07:02:26 UTC) #11
rwlbuis
lgtm
4 years, 5 months ago (2016-06-30 15:23:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1930823002/60001
4 years, 5 months ago (2016-07-01 01:41:11 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-01 03:01:12 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 03:01:19 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 03:04:30 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f
Cr-Commit-Position: refs/heads/master@{#403396}

Powered by Google App Engine
This is Rietveld 408576698