Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Issue 1930823002: Fix assertion when parsing @namespace/@import with url(<bad-string-token>) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blablabla Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/namespaces/invalid-url-in-namespace.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
index 543fd33aa6efe80885f4ed4fc1fd759f7d9a0bcc..ae32ea630f2c688fa5a30d682654e83318e8cbac 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
@@ -445,9 +445,9 @@ static AtomicString consumeStringOrURI(CSSParserTokenRange& range)
CSSParserTokenRange contents = range.consumeBlock();
const CSSParserToken& uri = contents.consumeIncludingWhitespace();
- ASSERT(uri.type() == StringToken);
- if (!contents.atEnd())
+ if (uri.type() == BadStringToken || !contents.atEnd())
return AtomicString();
+ DCHECK_EQ(uri.type(), StringToken);
return uri.value().toAtomicString();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/namespaces/invalid-url-in-namespace.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698