Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1930773006:
fix ipc_mojo_unittests.isolate dependencies (Closed)
|
Created:
4 years, 7 months ago by Mostyn Bramley-Moore Modified:
4 years, 7 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionfix ipc_mojo_unittests.isolate dependencies
BUG=604847
Committed: https://crrev.com/94d9e148d47990c72a76ce0cb8602d55418fea5e
Cr-Commit-Position: refs/heads/master@{#390606}
Patch Set 1 #
Total comments: 2
Patch Set 2 : apply Sam's suggestion instead #Messages
Total messages: 27 (12 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930773006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930773006/1
mostynb@opera.com changed reviewers: + jam@chromium.org, sammc@chromium.org
@jam, Sam: please take a look at this fixup to https://codereview.chromium.org/1918143004 Without this, the ipc_mojo_unittests_run can fail with something like: /home/user/code/chromium/src/out/Release/lib/libmojo_public_test_support.so doesn't exist
https://codereview.chromium.org/1930773006/diff/1/ipc/mojo/ipc_mojo.gyp File ipc/mojo/ipc_mojo.gyp (right): https://codereview.chromium.org/1930773006/diff/1/ipc/mojo/ipc_mojo.gyp#newco... ipc/mojo/ipc_mojo.gyp:114: '../../mojo/mojo_public.gyp:mojo_public_test_support', ipc_mojo_unittests doesn't actually need mojo_public_test_support. ipc_mojo_unittests.isolate should include ../../base/base.isolate instead of ../../mojo/mojo.isolate.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930773006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930773006/20001
Description was changed from ========== ipc_mojo_unittests_run depends on mojo_public_test_support BUG=604847 ========== to ========== fix ipc_mojo_unittests.isolate dependencies BUG=604847 ==========
https://codereview.chromium.org/1930773006/diff/1/ipc/mojo/ipc_mojo.gyp File ipc/mojo/ipc_mojo.gyp (right): https://codereview.chromium.org/1930773006/diff/1/ipc/mojo/ipc_mojo.gyp#newco... ipc/mojo/ipc_mojo.gyp:114: '../../mojo/mojo_public.gyp:mojo_public_test_support', On 2016/04/29 06:41:17, Sam McNally wrote: > ipc_mojo_unittests doesn't actually need mojo_public_test_support. > ipc_mojo_unittests.isolate should include ../../base/base.isolate instead of > ../../mojo/mojo.isolate. Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930773006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930773006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
mostynb@opera.com changed reviewers: + amistry@chromium.org
@Anand: can you please give this a thumbs-up for ipc/mojo/ ?
The CQ bit was checked by amistry@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930773006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930773006/20001
Message was sent while issue was closed.
Description was changed from ========== fix ipc_mojo_unittests.isolate dependencies BUG=604847 ========== to ========== fix ipc_mojo_unittests.isolate dependencies BUG=604847 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/94d9e148d47990c72a76ce0cb8602d55418fea5e Cr-Commit-Position: refs/heads/master@{#390606}
Message was sent while issue was closed.
Description was changed from ========== fix ipc_mojo_unittests.isolate dependencies BUG=604847 ========== to ========== fix ipc_mojo_unittests.isolate dependencies BUG=604847 Committed: https://crrev.com/94d9e148d47990c72a76ce0cb8602d55418fea5e Cr-Commit-Position: refs/heads/master@{#390606} ========== |
