Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1918143004: Convert Mojo tests to use swarming. (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Mojo tests to use swarming. BUG=604847 Committed: https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7 Cr-Commit-Position: refs/heads/master@{#390573}

Patch Set 1 : #

Total comments: 10

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -147 lines) Patch
M BUILD.gn View 1 2 1 chunk +22 lines, -5 lines 0 comments Download
M gin/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A + ipc/mojo/ipc_mojo_unittests.isolate View 1 chunk +4 lines, -5 lines 0 comments Download
M mojo/edk/js/test/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + mojo/mojo.isolate View 2 chunks +1 line, -14 lines 0 comments Download
M mojo/mojo_common_unittests.isolate View 2 chunks +1 line, -22 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/mojo_js_integration_tests.isolate View 1 1 chunk +49 lines, -0 lines 0 comments Download
M mojo/mojo_js_unittests.isolate View 2 chunks +22 lines, -24 lines 0 comments Download
M mojo/mojo_public_bindings_unittests.isolate View 2 chunks +1 line, -22 lines 0 comments Download
M mojo/mojo_public_system_unittests.isolate View 2 chunks +1 line, -22 lines 0 comments Download
A + mojo/mojo_system_unittests.isolate View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/js/BUILD.gn View 1 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/public/mojo_application_manifest.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/tools/apptest_runner.py View 3 chunks +29 lines, -0 lines 0 comments Download
M services/catalog/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + services/shell/mojo_shell_unittests.isolate View 1 chunk +4 lines, -5 lines 0 comments Download
M services/shell/shell.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
M services/shell/tests/connect/BUILD.gn View 4 chunks +12 lines, -4 lines 0 comments Download
M services/shell/tests/lifecycle/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M testing/buildbot/chromium.fyi.json View 20 chunks +84 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 10 chunks +57 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 4 chunks +19 lines, -11 lines 0 comments Download
M testing/test.gni View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Sam McNally
4 years, 7 months ago (2016-04-28 08:13:33 UTC) #16
jam
lgtm with minor comments to simplify build files https://codereview.chromium.org/1918143004/diff/280001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1918143004/diff/280001/BUILD.gn#newcode625 BUILD.gn:625: "//mojo/tools/mopy/__init__.py", ...
4 years, 7 months ago (2016-04-28 15:59:30 UTC) #17
Sam McNally
https://codereview.chromium.org/1918143004/diff/280001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1918143004/diff/280001/BUILD.gn#newcode625 BUILD.gn:625: "//mojo/tools/mopy/__init__.py", On 2016/04/28 15:59:29, jam wrote: > just make ...
4 years, 7 months ago (2016-04-29 00:21:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918143004/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918143004/320001
4 years, 7 months ago (2016-04-29 01:38:32 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:320001)
4 years, 7 months ago (2016-04-29 01:59:31 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:23:48 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98ecd4a58d5b625759b2121be8254cd1abec8dc7
Cr-Commit-Position: refs/heads/master@{#390573}

Powered by Google App Engine
This is Rietveld 408576698