Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930743003: Fix stack overflow from nested arrays. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : unsigned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 2 9 chunks +54 lines, -47 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-04-28 02:39:58 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/1930743003/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp File core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right): https://codereview.chromium.org/1930743003/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp#newcode36 core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp:36: const int kMaxNestedArrayLevel = 512; Can this be ...
4 years, 7 months ago (2016-04-28 16:07:11 UTC) #3
Lei Zhang
https://codereview.chromium.org/1930743003/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp File core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right): https://codereview.chromium.org/1930743003/diff/20001/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp#newcode36 core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp:36: const int kMaxNestedArrayLevel = 512; On 2016/04/28 16:07:11, Wei ...
4 years, 7 months ago (2016-04-28 21:32:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930743003/40001
4 years, 7 months ago (2016-04-28 21:33:33 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 21:45:33 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/8e957baa851aed4b02511d04a66c0f95387d...

Powered by Google App Engine
This is Rietveld 408576698