core/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 1930743003: Fix stack overflow from nested arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 1930743003: Fix stack overflow from nested arrays. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: unsigned Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index 93ea93dee76403bb50b8bc83c95ea0dae962b56d..7ed485c87cdf677975c1f5182a31d42dcae984e1 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -604,7 +604,7 @@ void CPDF_StreamContentParser::Handle_BeginImage() {

CFX_ByteString key((const FX_CHAR*)m_pSyntax->GetWordBuf() + 1,

m_pSyntax->GetWordSize() - 1);

std::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>> pObj(

- m_pSyntax->ReadNextObject());

+ m_pSyntax->ReadNextObject(false, 0));

if (!key.IsEmpty()) {

uint32_t dwObjNum = pObj ? pObj->GetObjNum() : 0;

if (dwObjNum)

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp » ('j') | no next file with comments »