Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1930663003: Modify dump_inferred_types.dart to handle missing unlinked units. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify dump_inferred_types.dart to handle missing unlinked units. In rare cases a summary package bundle may contain a LinkedLibrary object but not its corresponding UnlinkedUnits. (This could happen, for instance, if both a package and one of its dependencies contain libraries that reference the same file as a "part"--in this case, the UnlinkedUnit for the part might only be included in one of the package bundles, because it is redundant in the other). This CL modifies dump_inferred_types.dart so that it doesn't crash in this rare corner case. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/09c98dc45690a63da1e5e58a90845c69e020528e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M pkg/analyzer/tool/summary/dump_inferred_types.dart View 1 chunk +16 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-04-27 21:19:06 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-04-27 21:20:15 UTC) #3
Paul Berry
4 years, 7 months ago (2016-04-27 21:22:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09c98dc45690a63da1e5e58a90845c69e020528e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698