Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: pkg/analyzer/tool/summary/dump_inferred_types.dart

Issue 1930663003: Modify dump_inferred_types.dart to handle missing unlinked units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/dump_inferred_types.dart
diff --git a/pkg/analyzer/tool/summary/dump_inferred_types.dart b/pkg/analyzer/tool/summary/dump_inferred_types.dart
index 0668513ac1c63070a2835cea78b1cb360b0e209f..18c0ef47226a08286b0eeecb0575603631079a79 100644
--- a/pkg/analyzer/tool/summary/dump_inferred_types.dart
+++ b/pkg/analyzer/tool/summary/dump_inferred_types.dart
@@ -246,16 +246,22 @@ class InferredTypeCollector {
}
Uri libraryUri = Uri.parse(libraryUriString);
UnlinkedUnit definingUnlinkedUnit = unlinkedUnits[libraryUriString];
- visitUnit(definingUnlinkedUnit, linkedLibrary.units[0], libraryUriString);
- for (int i = 0;
- i < definingUnlinkedUnit.publicNamespace.parts.length;
- i++) {
- Uri relativePartUri =
- Uri.parse(definingUnlinkedUnit.publicNamespace.parts[i]);
- String unitUriString =
- resolveRelativeUri(libraryUri, relativePartUri).toString();
- visitUnit(unlinkedUnits[unitUriString], linkedLibrary.units[i + 1],
- libraryUriString);
+ if (definingUnlinkedUnit != null) {
+ visitUnit(
+ definingUnlinkedUnit, linkedLibrary.units[0], libraryUriString);
+ for (int i = 0;
+ i < definingUnlinkedUnit.publicNamespace.parts.length;
+ i++) {
+ Uri relativePartUri =
+ Uri.parse(definingUnlinkedUnit.publicNamespace.parts[i]);
+ String unitUriString =
+ resolveRelativeUri(libraryUri, relativePartUri).toString();
+ UnlinkedUnit unlinkedUnit = unlinkedUnits[unitUriString];
+ if (unlinkedUnit != null) {
+ visitUnit(
+ unlinkedUnit, linkedLibrary.units[i + 1], libraryUriString);
+ }
+ }
}
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698