Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1930633002: Fix gpu_ipc_service_unittests on mac_chromium_rel_ng by managing GL shared groups the same way in s… (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank, piman, dpranke, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gpu_ipc_service_unittests on mac_chromium_rel_ng by managing GL shared groups the same way in stub-case as in real-case. BUG=604935 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0 Cr-Commit-Position: refs/heads/master@{#390166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M gpu/ipc/service/gpu_command_buffer_stub.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M ui/gl/gl_context_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_ozone.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gl/gl_context_stub.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_context_stub.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930633002/1
4 years, 7 months ago (2016-04-27 19:07:33 UTC) #3
Mark Dittmer
sievers@, PTAL. Created this as a prerequisite to https://codereview.chromium.org/1908013002/. This fix should deal with this ...
4 years, 7 months ago (2016-04-27 19:16:31 UTC) #6
no sievers
On 2016/04/27 19:16:31, Mark Dittmer wrote: > sievers@, PTAL. > > Created this as a ...
4 years, 7 months ago (2016-04-27 19:21:13 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 20:21:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930633002/1
4 years, 7 months ago (2016-04-27 20:22:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 20:27:00 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b49a88516b4ac62c00541144f2519e1737316d0
Cr-Commit-Position: refs/heads/master@{#390166}

Powered by Google App Engine
This is Rietveld 408576698