Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1930503003: Remove font subpixel positioning flag (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
kojii
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove font subpixel positioning flag Remove the static FontCache::s_useSubpixelPositioning field and the bool FontPlatformData::m_useSubpixelPositioning field. They are only ever set explicitly on Windows and always to true since the GDI path was removed. BUG=579678 R=kojii@chromium.org Committed: https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55 Cr-Commit-Position: refs/heads/master@{#390337}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Retain test-only handling on linux #

Messages

Total messages: 12 (7 generated)
eae
4 years, 7 months ago (2016-04-28 05:17:11 UTC) #4
kojii
lgtm, nice cleanup!
4 years, 7 months ago (2016-04-28 05:54:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930503003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930503003/60001
4 years, 7 months ago (2016-04-28 07:28:53 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-04-28 09:55:53 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:15 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b331622a5bd93461fbcbff715d4a7b874dd56d55
Cr-Commit-Position: refs/heads/master@{#390337}

Powered by Google App Engine
This is Rietveld 408576698