third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp - Issue 1930503003: Remove font subpixel positioning flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 1930503003: Remove font subpixel positioning flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Retain test-only handling on linux Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp ('k') | third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

index eb36e267edc83274442f9edc0817bcb89a0d2638..731eb0a4dac7093307d14a0ba770e814f89a9739 100644

--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

@@ -101,9 +101,6 @@ FontCache::FontCache()

m_fontManager = s_fontManager;

if (!m_fontManager.get())

m_fontManager = adoptRef(SkFontMgr_New_DirectWrite());

- s_useSubpixelPositioning = true;

ASSERT(m_fontManager.get());

}

@@ -401,8 +398,7 @@ PassOwnPtr<FontPlatformData> FontCache::createFontPlatformData(const FontDescrip

fontSize,

(fontDescription.weight() >= FontWeight600 && !tf->isBold()) || fontDescription.isSyntheticBold(),

((fontDescription.style() == FontStyleItalic || fontDescription.style() == FontStyleOblique) && !tf->isItalic()) || fontDescription.isSyntheticItalic(),

- fontDescription.orientation(),

- s_useSubpixelPositioning));

+ fontDescription.orientation()));

struct FamilyMinSize {

const wchar_t* family;