Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 19305002: Merge 210098 "cc: Eliminate tile.h's dependency on tile_manager.h" (Closed)

Created:
7 years, 5 months ago by reveman
Modified:
7 years, 5 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Merge 210098 "cc: Eliminate tile.h's dependency on tile_manager.h" > cc: Eliminate tile.h's dependency on tile_manager.h > > Tile needs the raster mode and tile priority, which are > currently included via raster_worker_pool, which is included > by the tile manager. Since tile at the layer's level, it really > shouldn't include raster worker pool at any point. > > This patch moves raster mode and tile priority to a separate > tile data file. This would also be a good spot for combining > content_rect and contents_scale into TileRect (which is something > I'd like to do) > > BUG=253972 > > Review URL: https://chromiumcodereview.appspot.com/17625002 TBR=vmpstr@chromium.org BUG=253972, 257601 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -75 lines) Patch
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + cc/resources/raster_mode.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cc/resources/raster_mode.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 5 chunks +8 lines, -26 lines 0 comments Download
M cc/resources/raster_worker_pool.cc View 7 chunks +57 lines, -30 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M cc/resources/tile.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/resources/tile_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/resources/tile_manager.cc View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
7 years, 5 months ago (2013-07-15 23:03:16 UTC) #1
reveman
7 years, 5 months ago (2013-07-15 23:14:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r211725.

Powered by Google App Engine
This is Rietveld 408576698