Issue 1930403002: Remove HasUserGesture check from from gws metric logger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1930403002: Remove HasUserGesture check from from gws metric logger. (Closed)

Created:
4 years, 7 months ago by Charlie Harrison

Modified:
4 years, 7 months ago

Reviewers:
Bryan McQuade

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Remove HasUserGesture check from from gws metric logger. Navigations opened in new tabs return false for HasUserGesture, so we need to remove that check in order to support that case. BUG=607332 Review-Url: https://codereview.chromium.org/1915123007 Cr-Commit-Position: refs/heads/master@{#390228} (cherry picked from commit fc86df8278e4f3814e391c42fe9d34b3ef34f266) TBR=bmcquade@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ca8e6aeed2b78d0a7699ad9e4b1589a53795aac1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Charlie Harrison

4 years, 7 months ago (2016-04-29 14:10:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ca8e6aeed2b78d0a7699ad9e4b1589a53795aac1 (presubmit successful).