Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1915123007: Remove HasUserGesture check from from gws metric logger. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HasUserGesture check from from gws metric logger. Navigations opened in new tabs return false for HasUserGesture, so we need to remove that check in order to support that case. BUG=607332 Committed: https://crrev.com/fc86df8278e4f3814e391c42fe9d34b3ef34f266 Cr-Commit-Position: refs/heads/master@{#390228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Bryan McQuade
4 years, 7 months ago (2016-04-27 22:48:03 UTC) #2
Charlie Harrison
lgtm
4 years, 7 months ago (2016-04-27 23:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915123007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915123007/1
4 years, 7 months ago (2016-04-27 23:11:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 23:20:14 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc86df8278e4f3814e391c42fe9d34b3ef34f266
Cr-Commit-Position: refs/heads/master@{#390228}

Powered by Google App Engine
This is Rietveld 408576698