Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2294)

Unified Diff: content/public/browser/render_frame_host.h

Issue 1930393002: Switch stream creation and closing in Chrome audio rendering from IPC to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use wrap Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_frame_host.h
diff --git a/content/public/browser/render_frame_host.h b/content/public/browser/render_frame_host.h
index 980704cf16b18af25807b656539ea3bc0105cdc3..4122a73b6a191e324bdd9bf625ec250ef90883fd 100644
--- a/content/public/browser/render_frame_host.h
+++ b/content/public/browser/render_frame_host.h
@@ -24,6 +24,7 @@ class Value;
}
namespace content {
+class AudioOutputImpl;
nasko 2016/05/25 20:50:42 This is a violation of the content API. No Impl cl
rchtara 2016/05/27 15:24:39 Done.
class RenderProcessHost;
class RenderViewHost;
class RenderWidgetHostView;
@@ -50,6 +51,10 @@ class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,
~RenderFrameHost() override {}
+ virtual AudioOutputImpl* GetAudioOutputImpl() = 0;
nasko 2016/05/25 20:50:42 These two methods are not used anywhere, please re
rchtara 2016/05/27 15:24:39 Done.
+
+ virtual void SetAudioOutputImpl(AudioOutputImpl* audio_output_impl) = 0;
nasko 2016/05/25 20:50:42 Why do we have a set method on the public interfac
rchtara 2016/05/27 15:24:39 Done.
+
// Returns the route id for this frame.
virtual int GetRoutingID() = 0;

Powered by Google App Engine
This is Rietveld 408576698