Switch stream creation and closing in Chrome audio rendering from IPC to Mojo

content/public/browser/render_frame_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/public/common/console_message_level.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_sender.h"
 #include "third_party/WebKit/public/platform/WebPageVisibilityState.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/native_widget_types.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace base {
 class Value;
 }
 
 namespace content {
+class AudioOutputImpl;

[nasko, 2016/05/25 20:50:42]

This is a violation of the content API. No Impl classes are exposed outside of
content/.

[rchtara, 2016/05/27 15:24:39]

Done.

 class RenderProcessHost;
 class RenderViewHost;
 class RenderWidgetHostView;
 class ServiceRegistry;
 class SiteInstance;
 
 // The interface provides a communication conduit with a frame in the renderer.
 class CONTENT_EXPORT RenderFrameHost : public IPC::Listener,
                                        public IPC::Sender {
  public:
   // Returns the RenderFrameHost given its ID and the ID of its render process.
   // Returns nullptr if the IDs do not correspond to a live RenderFrameHost.
   static RenderFrameHost* FromID(int render_process_id, int render_frame_id);
 
 #if defined(OS_ANDROID)
   // Globally allows for injecting JavaScript into the main world. This feature
   // is present only to support Android WebView and must not be used in other
   // configurations.
   static void AllowInjectingJavaScriptForAndroidWebView();
 #endif
 
   // Returns a RenderFrameHost given its accessibility tree ID.
   static RenderFrameHost* FromAXTreeID(int ax_tree_id);
 
   ~RenderFrameHost() override {}
 
+  virtual AudioOutputImpl* GetAudioOutputImpl() = 0;

[nasko, 2016/05/25 20:50:42]

These two methods are not used anywhere, please remove them from the public API.

[rchtara, 2016/05/27 15:24:39]

Done.

+
+  virtual void SetAudioOutputImpl(AudioOutputImpl* audio_output_impl) = 0;

[nasko, 2016/05/25 20:50:42]

Why do we have a set method on the public interface? You also cannot have Impl
classes exposed outside of content, so this is incorrect.

[rchtara, 2016/05/27 15:24:39]

Done.

+
   // Returns the route id for this frame.
   virtual int GetRoutingID() = 0;
 
   // Returns the accessibility tree ID for this RenderFrameHost.
   virtual int GetAXTreeID() = 0;
 
   // Returns the SiteInstance grouping all RenderFrameHosts that have script
   // access to this RenderFrameHost, and must therefore live in the same
   // process.
   virtual SiteInstance* GetSiteInstance() = 0;
@@ skipping 120 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderFrameHostImpl;
   RenderFrameHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_