Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1930363003: Reland of git cl try: don't skip presubmit builders, but set dry_run property. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1928373002/ ) Reason for revert: Was me - too fast to pull the revert trigger. The CL in question has notry set to true :( Original issue's description: > Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) > > Reason for revert: > Now only presubmit is scheduled on dry run, example CL: > https://codereview.chromium.org/1804003002 > > Original issue's description: > > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > > > R=machenbach@chromium.org,sergiyb@chromium.org > > BUG=601128, 594127, 591030 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 > > TBR=sergiyb@chromium.org,tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=601128, 594127, 591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300337 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128, 594127, 591030 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M git_cl.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
Created Reland of git cl try: don't skip presubmit builders, but set dry_run property.
4 years, 7 months ago (2016-04-29 12:34:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930363003/1
4 years, 7 months ago (2016-04-29 12:34:37 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 12:34:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300338

Powered by Google App Engine
This is Rietveld 408576698