Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 193022: Use SSPI for NTLM authentication on Windows. (Closed)

Created:
11 years, 3 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Second attempt of r25461] Use SSPI for NTLM authentication on Windows. Add an explicit embedded_identity_used_ boolean member to make sure we use the username/password in the URL only once for the transaction. This allows us to reset auth_identity_[target].source to HttpAuth::IDENT_SRC_NONE after auth failed. Initial patch by Arindam. Original review URL: http://codereview.chromium.org/159656 R=arindam,eroman BUG=19, 18009, 20560 TEST=1. Open a webpage that requests NTLM authentication on Windows. 2. New unit test for wrong auth identity in URL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25564

Patch Set 1 #

Patch Set 2 : Add embedded_identity_used_ #

Patch Set 3 : Forgot to add http_network_transaction.h to the CL. #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -700 lines) Patch
M net/http/http_auth_handler.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 1 2 3 6 chunks +38 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 2 3 4 chunks +3 lines, -687 lines 0 comments Download
M net/http/http_network_transaction.h View 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 7 chunks +25 lines, -10 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 5 5 chunks +120 lines, -2 lines 0 comments Download
M net/net.gyp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A + net\http\http_auth_handler_ntlm_portable.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net\http\http_auth_handler_ntlm_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
11 years, 3 months ago (2009-09-05 00:13:09 UTC) #1
eroman
11 years, 3 months ago (2009-09-05 00:32:27 UTC) #2
LGTM.

Thanks for adding the new unittest!

http://codereview.chromium.org/193022/diff/6011/7009
File net/http/http_network_transaction_unittest.cc (right):

http://codereview.chromium.org/193022/diff/6011/7009#newcode2234
Line 2234: request.load_flags = 0;
can you use LOAD_NORMAL instead?

Hmm, seems we do the " = 0" business elsewhere.

Powered by Google App Engine
This is Rietveld 408576698