Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1930103002: Fixes the spacing between the buttons on the Sync Confirmation Screen (MacOS and Linux) (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sync-confirmation-bug-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When the flex-direction is reversed the margins should also be updated. BUG=595349 Committed: https://crrev.com/4d18842b4c0fb273bab0ed27431e55c9c771bb2b Cr-Commit-Position: refs/heads/master@{#390473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/resources/sync_confirmation/sync_confirmation.html View 1 chunk +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Moe
Hi Michael, Please review this patch.
4 years, 7 months ago (2016-04-28 19:46:27 UTC) #3
michaelpg
lgtm
4 years, 7 months ago (2016-04-28 19:47:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930103002/1
4 years, 7 months ago (2016-04-28 20:48:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 20:54:04 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d18842b4c0fb273bab0ed27431e55c9c771bb2b
Cr-Commit-Position: refs/heads/master@{#390473}

Powered by Google App Engine
This is Rietveld 408576698