content_shell fixes for gn

content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015
Committed: https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845
Cr-Commit-Position: refs/heads/master@{#391018}

[brucedawson, 2016-04-28 21:25:56]

Description was changed from

==========
Conditionally disable incremental linking for content_shell

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

BUG=603015
==========

to

==========
content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015
==========

[brucedawson, 2016-04-28 23:22:05]

brucedawson@chromium.org changed reviewers:
+ jochen@chromium.org

[brucedawson, 2016-04-28 23:23:21]

Simple changes to improve content_shell gn builds.

The gn content_shell.exe now contains the same resources as the gyp one, plus 20
32x32x1-bit cursors - I don't know where they come from.

[brucedawson, 2016-04-29 18:50:51]

PTAL. I could get brettw@ to look but I want to load balance some gn changes
away from him.

[jochen (gone - plz use gerrit), 2016-05-02 17:01:16]

lgtm

[brucedawson, 2016-05-02 17:05:58]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-02 17:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930073002/20001

[commit-bot: I haz the power, 2016-05-02 19:04:09]

Description was changed from

==========
content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015
==========

to

==========
content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015
==========

[commit-bot: I haz the power, 2016-05-02 19:04:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 19:06:27]

Description was changed from

==========
content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015
==========

to

==========
content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG=603015

Committed: https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845
Cr-Commit-Position: refs/heads/master@{#391018}
==========

[commit-bot: I haz the power, 2016-05-02 19:06:28]

Patchset 2 (id:??) landed as
https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845
Cr-Commit-Position: refs/heads/master@{#391018}