Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2963)

Unified Diff: content/shell/BUILD.gn

Issue 1930073002: content_shell fixes for gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding shell.rc Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index caf5ad90d9234a222de8b06bf3929afc15069b75..47fc5d9b7a1d1bf06136fbb342ac8da5c58c0272 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -268,7 +268,6 @@ static_library("content_shell_lib") {
}
if (is_win) {
- #'LinkIncremental': '<(msvs_large_module_debug_link_mode)', TODO(GYP)
sources += [
"common/v8_breakpad_support_win.cc",
"common/v8_breakpad_support_win.h",
@@ -443,13 +442,14 @@ if (is_android) {
testonly = true
# TODO(GYP) mac resource bundle stuff for this target.
- # TODO(GYP) Windows content shell settings:
- # - RC file.
- # - 'LinkIncremental': '<(msvs_large_module_debug_link_mode)',
sources = [
"app/shell_main.cc",
]
+ if (is_win) {
+ sources += [ "app/shell.rc" ]
+ }
+
defines = []
deps = [
@@ -461,6 +461,11 @@ if (is_android) {
if (is_win) {
deps += [ "//sandbox" ]
+
+ # This is a large module that can't do incremental linking in some cases.
+ configs -= [ "//build/config/win:default_incremental_linking" ]
+ configs +=
+ [ "//build/config/win:default_large_module_incremental_linking" ]
if (win_console_app) {
defines += [ "WIN_CONSOLE_APP" ]
} else {
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698