Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1930033003: [Extensions] Make Binding.generate() load the schema directly (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make Binding.generate() load the schema directly Previously, Binding.generate would rely on a previously-loaded schema object during generation. Instead, make it load the schema directly in generate() so that it can't be mutated before use. BUG=591164 BUG=604901 Review URL: https://codereview.chromium.org/1864353002 Cr-Commit-Position: refs/heads/master@{#386434} (cherry picked from commit c089219d5f8794747f7ab7b966b4676f49532e1f) Committed: https://chromium.googlesource.com/chromium/src/+/970dbc743f2a107f14bb120341c322380a7c71cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M extensions/renderer/resources/binding.js View 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 7 months ago (2016-04-28 22:17:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
970dbc743f2a107f14bb120341c322380a7c71cd.

Powered by Google App Engine
This is Rietveld 408576698