[Extensions] Make Binding.generate() load the schema directly

[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164
Committed: https://crrev.com/c089219d5f8794747f7ab7b966b4676f49532e1f
Cr-Commit-Position: refs/heads/master@{#386434}

[Devlin, 2016-04-08 21:58:26]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-04-08 22:00:24]

Description was changed from

==========
foo2

BUG=
==========

to

==========
[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164
==========

[Devlin, 2016-04-08 22:00:55]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-04-11 18:13:44]

lgtm

https://codereview.chromium.org/1864353002/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1864353002/diff/20001/extensions/renderer/res...
extensions/renderer/resources/binding.js:238: // handler, it's properties don't
have the custom getters/setters that
grammar nazi: this should be "its" instead of "it's"

[Devlin, 2016-04-11 19:10:03]

https://codereview.chromium.org/1864353002/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/1864353002/diff/20001/extensions/renderer/res...
extensions/renderer/resources/binding.js:238: // handler, it's properties don't
have the custom getters/setters that
On 2016/04/11 18:13:44, Antony Sargent wrote:
> grammar nazi: this should be "its" instead of "it's"

whoops, fixed.

[Devlin, 2016-04-11 19:10:07]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-04-11 19:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1864353002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-04-11 19:10:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864353002/40001

[commit-bot: I haz the power, 2016-04-11 19:17:19]

Description was changed from

==========
[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164
==========

to

==========
[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164
==========

[commit-bot: I haz the power, 2016-04-11 19:17:20]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-11 19:18:18]

Description was changed from

==========
[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164
==========

to

==========
[Extensions] Make Binding.generate() load the schema directly

Previously, Binding.generate would rely on a previously-loaded schema object
during generation. Instead, make it load the schema directly in generate() so
that it can't be mutated before use.

BUG=591164

Committed: https://crrev.com/c089219d5f8794747f7ab7b966b4676f49532e1f
Cr-Commit-Position: refs/heads/master@{#386434}
==========

[commit-bot: I haz the power, 2016-04-11 19:18:19]

Patchset 2 (id:??) landed as
https://crrev.com/c089219d5f8794747f7ab7b966b4676f49532e1f
Cr-Commit-Position: refs/heads/master@{#386434}