(Mostly) Retract GrRenderTarget from SkGpuDevice

(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way to having SkGpuDevice exclusively use a GrDrawContext instead of a GrRenderTarget. There are a few other refactorings (e.g., rm need for fLegacyBitmap and accessRenderTarget) before the GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry point to GrDrawContext)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930013002

Committed: https://skia.googlesource.com/skia/+/ca6eafc0f7e59ed89f03a9891b9fdf7de64f1f35

[robertphillips, 2016-04-28 16:46:46]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-02 17:33:03]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-02 17:33:38]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-05 18:22:33]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-15 18:30:05]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-15 18:37:40]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-16 17:52:01]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way there to having SkGpuDevice exclusively use a
GrDrawContext instead of a GrRenderTarget. There are a few other refactorings
(e.g., rm need for fLegacyBitmap and accessRenderTarget) before the
GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-16 17:52:02]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-05-16 17:52:23]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way there to having SkGpuDevice exclusively use a
GrDrawContext instead of a GrRenderTarget. There are a few other refactorings
(e.g., rm need for fLegacyBitmap and accessRenderTarget) before the
GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way to having SkGpuDevice exclusively use a
GrDrawContext instead of a GrRenderTarget. There are a few other refactorings
(e.g., rm need for fLegacyBitmap and accessRenderTarget) before the
GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-05-17 12:20:26]

ping

[bsalomon, 2016-05-17 13:01:06]

lgtm

[robertphillips, 2016-05-17 13:03:28]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 13:03:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930013002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930013002/280001

[commit-bot: I haz the power, 2016-05-17 13:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 13:44:23]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[robertphillips, 2016-05-17 16:19:18]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 16:19:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930013002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930013002/280001

[commit-bot: I haz the power, 2016-05-17 16:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 16:50:58]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-05-17 16:56:33]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-05-17 16:56:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930013002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930013002/280001

[commit-bot: I haz the power, 2016-05-17 16:57:49]

Description was changed from

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way to having SkGpuDevice exclusively use a
GrDrawContext instead of a GrRenderTarget. There are a few other refactorings
(e.g., rm need for fLegacyBitmap and accessRenderTarget) before the
GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
(Mostly) Retract GrRenderTarget from SkGpuDevice

This gets us most of the way to having SkGpuDevice exclusively use a
GrDrawContext instead of a GrRenderTarget. There are a few other refactorings
(e.g., rm need for fLegacyBitmap and accessRenderTarget) before the
GrRenderTarget can be completely removed.

Has calved off:
https://codereview.chromium.org/1925313002/ (Tighten up SkSpecialSurface factory
functions)
https://codereview.chromium.org/1925803004/ (Add sk_sp to SkSurface_Gpu and
SkGpuDevice)
https://codereview.chromium.org/1956473002/ (Retract GrRenderTarget a bit within
SkGpuDevice)
https://codereview.chromium.org/1979913002/ (Rename GrDrawingMgr::abandon to
wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/1982583002/ (Add isUnifiedMultisampled entry
point to GrDrawContext)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ca6eafc0f7e59ed89f03a9891b9fdf7de64f1f35
==========

[commit-bot: I haz the power, 2016-05-17 16:57:50]

Committed patchset #15 (id:280001) as
https://skia.googlesource.com/skia/+/ca6eafc0f7e59ed89f03a9891b9fdf7de64f1f35