Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3078)

Unified Diff: chrome/browser/password_manager/credential_manager_browsertest.cc

Issue 1929953002: Suppress the autofill password manager after a credential was saved via the API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/credential_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/credential_manager_browsertest.cc b/chrome/browser/password_manager/credential_manager_browsertest.cc
index c8889467ec2d596420a8c0d3afc312c86a64c121..378d660ed76bee24d59fe8325813e7d52fac8657 100644
--- a/chrome/browser/password_manager/credential_manager_browsertest.cc
+++ b/chrome/browser/password_manager/credential_manager_browsertest.cc
@@ -122,4 +122,29 @@ IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
EXPECT_FALSE(prompt_observer->IsShowingPrompt());
}
+IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest, SaveViaAPIAndAutofill) {
+ NavigateToFile("/password/password_form.html");
+ std::string fill_password =
+ "document.getElementById('username_field').value = 'user';"
+ "document.getElementById('password_field').value = '12345';";
+ ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_password));
+
+ // Call the API to save the form.
+ ASSERT_TRUE(content::ExecuteScript(
+ RenderViewHost(),
+ "var c = new PasswordCredential({ id: 'user', password: '12345' });"
+ "navigator.credentials.store(c);"));
+ std::unique_ptr<PromptObserver> prompt_observer(
+ PromptObserver::Create(WebContents()));
+ EXPECT_TRUE(prompt_observer->IsShowingPrompt());
+ prompt_observer->Dismiss();
+
+ NavigationObserver form_submit_observer(WebContents());
+ ASSERT_TRUE(content::ExecuteScript(
+ RenderViewHost(),
+ "document.getElementById('input_submit_button').click();"));
+ form_submit_observer.Wait();
+ EXPECT_FALSE(prompt_observer->IsShowingPrompt());
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698