Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1929933002: Drop build dependency on webrtc's legacy video_render module. (Closed)

Created:
4 years, 7 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop build dependency on webrtc's legacy video_render module. BUG=webrtc:5817 Committed: https://crrev.com/8014811b263dfd71c158a399b90f2b0896c194b2 Cr-Commit-Position: refs/heads/master@{#390385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-chromium (ooo August 14)
Hi, if this looks ok, I'd be happy if you could start a cq dry ...
4 years, 7 months ago (2016-04-28 13:02:51 UTC) #2
pbos
lgtm, can't help you with the CQ though :)
4 years, 7 months ago (2016-04-28 13:26:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929933002/1
4 years, 7 months ago (2016-04-28 13:26:37 UTC) #5
kjellander_chromium
lgtm
4 years, 7 months ago (2016-04-28 13:50:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929933002/1
4 years, 7 months ago (2016-04-28 14:24:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 15:13:36 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8014811b263dfd71c158a399b90f2b0896c194b2
Cr-Commit-Position: refs/heads/master@{#390385}

Powered by Google App Engine
This is Rietveld 408576698