Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1929853002: Propagate not-found on proxy target to GetRealNamedProperty (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Propagate not-found on proxy target to GetRealNamedProperty BUG=v8:4932 LOG=n Committed: https://crrev.com/adc02150729690c2907a2c55043b9ce3cddb554a Cr-Commit-Position: refs/heads/master@{#35846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-28 07:51:03 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-28 07:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929853002/1
4 years, 7 months ago (2016-04-28 07:59:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 08:24:47 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adc02150729690c2907a2c55043b9ce3cddb554a
Cr-Commit-Position: refs/heads/master@{#35846}

Powered by Google App Engine
This is Rietveld 408576698