Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: test/cctest/test-api.cc

Issue 1929853002: Propagate not-found on proxy target to GetRealNamedProperty (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 7c7fed5cda40c2c73393c623efb2f36935a09c74..a6d1de705aca385323251e0d3fd46f70fda25dde 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -12870,6 +12870,19 @@ THREADED_TEST(VariousGetPropertiesAndThrowingCallbacks) {
CHECK(try_catch.HasCaught());
try_catch.Reset();
CHECK(result.IsEmpty());
+
+ Local<Object> target = CompileRun("({})").As<Object>();
+ Local<Object> handler = CompileRun("({})").As<Object>();
+ Local<v8::Proxy> proxy =
+ v8::Proxy::New(context.local(), target, handler).ToLocalChecked();
+
+ result = target->GetRealNamedProperty(context.local(), v8_str("f"));
+ CHECK(!try_catch.HasCaught());
+ CHECK(result.IsEmpty());
+
+ result = proxy->GetRealNamedProperty(context.local(), v8_str("f"));
+ CHECK(!try_catch.HasCaught());
+ CHECK(result.IsEmpty());
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698