Events should have an initialized flag.

Events should have an initialized flag.

Events should have an initialized flag whose state
is used during EventTarget's dispatchEvent function call.

Spec: https://dom.spec.whatwg.org/#initialized-flag
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent

BUG=569686
Committed: https://crrev.com/b1edb653cbd7c43b406a18fb3d9ea41084ba3f99
Cr-Commit-Position: refs/heads/master@{#390899}

[ramya.v, 2016-04-28 08:41:41]

ramya.v@samsung.com changed reviewers:
+ philipj@opera.com, tkent@chromium.org

[ramya.v, 2016-04-28 08:41:41]

PTAL!

Thanks

[philipj_slow, 2016-04-28 09:39:08]

philipj@opera.com changed reviewers:
- philipj@opera.com

[philipj_slow, 2016-04-28 09:39:09]

This is my last week at Opera so I'm unable to take on new reviews, I'm afraid.

[tkent, 2016-05-02 00:19:27]

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:3950:
event->unsetInitializedFlag();
This code implements what the specification says as is.
https://dom.spec.whatwg.org/#dom-document-createevent

However, I don't think this is good for code readability and code encapsulation.
I'd like
 - Remove unsetInitializedFlag()
 - Initialize the flag with 'false' in the no-argument Event constructor.

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:174: bool initialized() { return
m_initialized; }
This function should be named as |wasInitialized()|

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:244: unsigned m_initialized:1;
This member should be named as |m_wasInitialized|

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:363: ASSERT(event &&
event->initialized());
nit: Split this into two.
    DCHECK(event);
    DCHECK(event->wasInitialized());

[ramya.v, 2016-05-02 05:31:44]

PTAL!

Thanks

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:3950:
event->unsetInitializedFlag();
On 2016/05/02 00:19:27, tkent wrote:
> This code implements what the specification says as is.
> https://dom.spec.whatwg.org/#dom-document-createevent
> 
> However, I don't think this is good for code readability and code
encapsulation.
> I'd like
>  - Remove unsetInitializedFlag()
>  - Initialize the flag with 'false' in the no-argument Event constructor.

Done.

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:174: bool initialized() { return
m_initialized; }
On 2016/05/02 00:19:27, tkent wrote:
> This function should be named as |wasInitialized()|

Done.

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:244: unsigned m_initialized:1;
On 2016/05/02 00:19:27, tkent wrote:
> This member should be named as |m_wasInitialized|

Done.

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/1929843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventTarget.cpp:363: ASSERT(event &&
event->initialized());
On 2016/05/02 00:19:27, tkent wrote:
> nit: Split this into two.
>     DCHECK(event);
>     DCHECK(event->wasInitialized());

Done.

[tkent, 2016-05-02 05:37:33]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-05-02 05:37:33]

lgtm

[commit-bot: I haz the power, 2016-05-02 05:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929843002/40001

[commit-bot: I haz the power, 2016-05-02 07:50:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 07:52:21]

Description was changed from

==========
Events should have an initialized flag.

Events should have an initialized flag whose state
is used during EventTarget's dispatchEvent function call.

Spec: https://dom.spec.whatwg.org/#initialized-flag
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent

BUG=569686
==========

to

==========
Events should have an initialized flag.

Events should have an initialized flag whose state
is used during EventTarget's dispatchEvent function call.

Spec: https://dom.spec.whatwg.org/#initialized-flag
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent

BUG=569686

Committed: https://crrev.com/b1edb653cbd7c43b406a18fb3d9ea41084ba3f99
Cr-Commit-Position: refs/heads/master@{#390899}
==========

[commit-bot: I haz the power, 2016-05-02 07:52:22]

Patchset 3 (id:??) landed as
https://crrev.com/b1edb653cbd7c43b406a18fb3d9ea41084ba3f99
Cr-Commit-Position: refs/heads/master@{#390899}