Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/core/events/Event.cpp

Issue 1929843002: Events should have an initialized flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de) 3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 || eventType == EventTypeNames::resize 44 || eventType == EventTypeNames::resize
45 || eventType == EventTypeNames::scroll 45 || eventType == EventTypeNames::scroll
46 || eventType == EventTypeNames::select 46 || eventType == EventTypeNames::select
47 || eventType == EventTypeNames::selectstart 47 || eventType == EventTypeNames::selectstart
48 || eventType == EventTypeNames::slotchange); 48 || eventType == EventTypeNames::slotchange);
49 } 49 }
50 50
51 Event::Event() 51 Event::Event()
52 : Event("", false, false, false) 52 : Event("", false, false, false)
53 { 53 {
54 m_wasInitialized = false;
54 } 55 }
55 56
56 Event::Event(const AtomicString& eventType, bool canBubbleArg, bool cancelableAr g) 57 Event::Event(const AtomicString& eventType, bool canBubbleArg, bool cancelableAr g)
57 : Event(eventType, canBubbleArg, cancelableArg, defaultScopedFromEventType(e ventType), false, monotonicallyIncreasingTime()) 58 : Event(eventType, canBubbleArg, cancelableArg, defaultScopedFromEventType(e ventType), false, monotonicallyIncreasingTime())
58 { 59 {
59 } 60 }
60 61
61 Event::Event(const AtomicString& eventType, bool canBubbleArg, bool cancelableAr g, EventTarget* relatedTarget) 62 Event::Event(const AtomicString& eventType, bool canBubbleArg, bool cancelableAr g, EventTarget* relatedTarget)
62 : Event(eventType, canBubbleArg, cancelableArg, defaultScopedFromEventType(e ventType), relatedTarget ? true : false, monotonicallyIncreasingTime()) 63 : Event(eventType, canBubbleArg, cancelableArg, defaultScopedFromEventType(e ventType), relatedTarget ? true : false, monotonicallyIncreasingTime())
63 { 64 {
(...skipping 18 matching lines...) Expand all
82 : m_type(eventType) 83 : m_type(eventType)
83 , m_canBubble(canBubbleArg) 84 , m_canBubble(canBubbleArg)
84 , m_cancelable(cancelableArg) 85 , m_cancelable(cancelableArg)
85 , m_scoped(scoped) 86 , m_scoped(scoped)
86 , m_relatedTargetScoped(relatedTargetScoped) 87 , m_relatedTargetScoped(relatedTargetScoped)
87 , m_propagationStopped(false) 88 , m_propagationStopped(false)
88 , m_immediatePropagationStopped(false) 89 , m_immediatePropagationStopped(false)
89 , m_defaultPrevented(false) 90 , m_defaultPrevented(false)
90 , m_defaultHandled(false) 91 , m_defaultHandled(false)
91 , m_cancelBubble(false) 92 , m_cancelBubble(false)
93 , m_wasInitialized(true)
92 , m_isTrusted(false) 94 , m_isTrusted(false)
93 , m_handlingPassive(false) 95 , m_handlingPassive(false)
94 , m_eventPhase(0) 96 , m_eventPhase(0)
95 , m_currentTarget(nullptr) 97 , m_currentTarget(nullptr)
96 , m_createTime(convertSecondsToDOMTimeStamp(currentTime())) 98 , m_createTime(convertSecondsToDOMTimeStamp(currentTime()))
97 , m_platformTimeStamp(platformTimeStamp) 99 , m_platformTimeStamp(platformTimeStamp)
98 { 100 {
99 } 101 }
100 102
101 Event::Event(const AtomicString& eventType, const EventInit& initializer) 103 Event::Event(const AtomicString& eventType, const EventInit& initializer)
102 : Event(eventType, initializer.bubbles(), initializer.cancelable(), initiali zer.scoped(), initializer.relatedTargetScoped(), monotonicallyIncreasingTime()) 104 : Event(eventType, initializer.bubbles(), initializer.cancelable(), initiali zer.scoped(), initializer.relatedTargetScoped(), monotonicallyIncreasingTime())
103 { 105 {
104 } 106 }
105 107
106 Event::~Event() 108 Event::~Event()
107 { 109 {
108 } 110 }
109 111
110 void Event::initEvent(const AtomicString& eventTypeArg, bool canBubbleArg, bool cancelableArg) 112 void Event::initEvent(const AtomicString& eventTypeArg, bool canBubbleArg, bool cancelableArg)
111 { 113 {
112 initEvent(eventTypeArg, canBubbleArg, cancelableArg, nullptr); 114 initEvent(eventTypeArg, canBubbleArg, cancelableArg, nullptr);
113 } 115 }
114 116
115 void Event::initEvent(const AtomicString& eventTypeArg, bool canBubbleArg, bool cancelableArg, EventTarget* relatedTarget) 117 void Event::initEvent(const AtomicString& eventTypeArg, bool canBubbleArg, bool cancelableArg, EventTarget* relatedTarget)
116 { 118 {
117 if (isBeingDispatched()) 119 if (isBeingDispatched())
118 return; 120 return;
119 121
122 m_wasInitialized = true;
120 m_propagationStopped = false; 123 m_propagationStopped = false;
121 m_immediatePropagationStopped = false; 124 m_immediatePropagationStopped = false;
122 m_defaultPrevented = false; 125 m_defaultPrevented = false;
123 m_isTrusted = false; 126 m_isTrusted = false;
124 127
125 m_type = eventTypeArg; 128 m_type = eventTypeArg;
126 m_canBubble = canBubbleArg; 129 m_canBubble = canBubbleArg;
127 m_cancelable = cancelableArg; 130 m_cancelable = cancelableArg;
128 131
129 m_relatedTargetScoped = relatedTarget ? true : false; 132 m_relatedTargetScoped = relatedTarget ? true : false;
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 360
358 DEFINE_TRACE(Event) 361 DEFINE_TRACE(Event)
359 { 362 {
360 visitor->trace(m_currentTarget); 363 visitor->trace(m_currentTarget);
361 visitor->trace(m_target); 364 visitor->trace(m_target);
362 visitor->trace(m_underlyingEvent); 365 visitor->trace(m_underlyingEvent);
363 visitor->trace(m_eventPath); 366 visitor->trace(m_eventPath);
364 } 367 }
365 368
366 } // namespace blink 369 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/Event.h ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698