Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 1929833004: Revert of Refactor drawContext/RenderTarget creation (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Refactor drawContext/RenderTarget creation (patchset #8 id:140001 of https://codereview.chromium.org/1914883002/ ) Reason for revert: Experimental revert to see if this is blocking the DEPS roll. Original issue's description: > Refactor drawContext/RenderTarget creation > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002 > > Committed: https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/aa19a5fbc58e372df11443c90a25f02a04ecef52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -157 lines) Patch
M include/gpu/GrContext.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +13 lines, -4 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +17 lines, -9 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +13 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +13 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 3 chunks +26 lines, -15 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 4 chunks +17 lines, -9 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 4 chunks +33 lines, -30 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 2 chunks +19 lines, -14 lines 0 comments Download
M tests/ClearTest.cpp View 11 chunks +28 lines, -14 lines 0 comments Download
M tests/ClipBoundsTest.cpp View 2 chunks +15 lines, -3 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Refactor drawContext/RenderTarget creation
4 years, 7 months ago (2016-04-28 13:21:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929833004/1
4 years, 7 months ago (2016-04-28 13:21:48 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 13:21:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa19a5fbc58e372df11443c90a25f02a04ecef52

Powered by Google App Engine
This is Rietveld 408576698