Login Screen for Mus

This is a v1 effort for enabling the login process with Mus. It involves disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being looked at, however it is account specific and release builds bypass this.

Committed: https://crrev.com/2d29e94113e479e577eb146bf497a0fbb11a07ce
Cr-Commit-Position: refs/heads/master@{#391608}

[jonross, 2016-04-27 23:24:07]

Description was changed from

==========
WIP Login Screen for Mus
==========

to

==========
This is a v1 effort for enabling the login process with Mus. It involves
disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the
mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being
looked at, however it is account specific and release builds bypass this.
==========

[jonross, 2016-04-27 23:25:09]

jonross@chromium.org changed reviewers:
+ sadrul@chromium.org

[jonross, 2016-04-27 23:25:09]

Hey Sadrul,

This is a first pass of the login screen. It allows login to work with the mash
shell. Could you take an initial look?

Thanks,
Jon

[jonross, 2016-04-29 17:52:53]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-04-29 17:52:53]

Hey Sky,

Could you provide an owners review to this change? I'm disabling a series of
features in the login screen, so that it is able to run in the mash shell.

Thanks,
Jon

[sky, 2016-05-02 15:00:03]

Do you need NOTIMPLEMENTEDs in the disabled functions? If not, please add
comments as to why mash is different.

https://codereview.chromium.org/1929733002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/1929733002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/session/user_session_manager.cc:1733: if
(chrome::IsRunningInMash()) {
nit: move above 1730 as you don't use user at all.

[jonross, 2016-05-04 14:22:00]

Patchset #5 (id:80001) has been deleted

[jonross, 2016-05-04 14:23:21]

For sections where entire methods are disabled, I've added NOTIMPLEMENTEDs. For
some features (like disabled animations) where the code is strewn across a file,
I've added comments to document the Mash checks.

https://codereview.chromium.org/1929733002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/1929733002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/session/user_session_manager.cc:1733: if
(chrome::IsRunningInMash()) {
On 2016/05/02 15:00:03, sky wrote:
> nit: move above 1730 as you don't use user at all.

Done.

[sky, 2016-05-04 17:31:32]

LGTM

[jonross, 2016-05-04 17:47:07]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929733002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929733002/100001

[commit-bot: I haz the power, 2016-05-04 20:03:02]

Description was changed from

==========
This is a v1 effort for enabling the login process with Mus. It involves
disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the
mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being
looked at, however it is account specific and release builds bypass this.
==========

to

==========
This is a v1 effort for enabling the login process with Mus. It involves
disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the
mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being
looked at, however it is account specific and release builds bypass this.
==========

[commit-bot: I haz the power, 2016-05-04 20:03:03]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-05-04 20:04:49]

Description was changed from

==========
This is a v1 effort for enabling the login process with Mus. It involves
disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the
mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being
looked at, however it is account specific and release builds bypass this.
==========

to

==========
This is a v1 effort for enabling the login process with Mus. It involves
disabling a series of unsupported services:
  - ui::UserActivityDetector
  - InputEventsBlocker
  - the login screens animations
  - waiting upon the background service
  - aura::client::ScopedDragDropDisabler
  - VirtualKeyboard
  - ash's StatusArea
  - ash's SystemTray
  - AccessibilityManager
  - ash::ScreenDimmer
  - TouchViewControllerDelegate

The login process works, bringing up a logged in instance of chrome with the
mash shell.

With some test accounts DCHECKs in sync code was being triggered. This is being
looked at, however it is account specific and release builds bypass this.

Committed: https://crrev.com/2d29e94113e479e577eb146bf497a0fbb11a07ce
Cr-Commit-Position: refs/heads/master@{#391608}
==========

[commit-bot: I haz the power, 2016-05-04 20:04:51]

Patchset 5 (id:??) landed as
https://crrev.com/2d29e94113e479e577eb146bf497a0fbb11a07ce
Cr-Commit-Position: refs/heads/master@{#391608}