Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 1929733002: Login Screen for Mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Document disabled features Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index 12147049f0aa61ac9faea1d323d6a82c104f6fab..a84850e1fd1a5acc00918fbf8e543d8ccc2567e3 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/renderer_preferences_util.h"
#include "chrome/browser/sessions/session_tab_helper.h"
+#include "chrome/browser/ui/ash/ash_util.h"
#include "chrome/browser/ui/autofill/chrome_autofill_client.h"
#include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
#include "chromeos/dbus/dbus_thread_manager.h"
@@ -167,9 +168,12 @@ WebUILoginView::~WebUILoginView() {
observer_list_,
OnHostDestroying());
- if (ash::Shell::GetInstance()->HasPrimaryStatusArea()) {
+ if (!chrome::IsRunningInMash() &&
+ ash::Shell::GetInstance()->HasPrimaryStatusArea()) {
ash::Shell::GetInstance()->GetPrimarySystemTray()->
SetNextFocusableView(NULL);
+ } else {
+ NOTIMPLEMENTED();
}
}
@@ -307,7 +311,8 @@ void WebUILoginView::OnPostponedShow() {
}
void WebUILoginView::SetStatusAreaVisible(bool visible) {
- if (ash::Shell::GetInstance()->HasPrimaryStatusArea()) {
+ if (!chrome::IsRunningInMash() &&
+ ash::Shell::GetInstance()->HasPrimaryStatusArea()) {
ash::SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
tray->SetVisible(visible);
if (visible) {
@@ -316,11 +321,17 @@ void WebUILoginView::SetStatusAreaVisible(bool visible) {
} else {
tray->GetWidget()->Hide();
}
+ } else {
+ NOTIMPLEMENTED();
}
}
void WebUILoginView::SetUIEnabled(bool enabled) {
forward_keyboard_event_ = enabled;
+ if (chrome::IsRunningInMash()) {
+ NOTIMPLEMENTED();
+ return;
+ }
ash::SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
// We disable the UI to prevent user from interracting with UI elements,
@@ -420,6 +431,11 @@ bool WebUILoginView::TakeFocus(content::WebContents* source, bool reverse) {
if (!forward_keyboard_event_)
return false;
+ // Focus is accepted, but the Ash system tray is not available in Mash, so
+ // exit early.
+ if (chrome::IsRunningInMash())
+ return true;
+
ash::SystemTray* tray = ash::Shell::GetInstance()->GetPrimarySystemTray();
if (tray && tray->GetWidget()->IsVisible()) {
tray->SetNextFocusableView(this);
« no previous file with comments | « chrome/browser/chromeos/login/ui/webui_login_display.cc ('k') | chrome/browser/chromeos/login/wizard_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698