Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1929543002: [DevTools] Device frames setting shouldn't be enabled by default (Closed)

Created:
4 years, 7 months ago by mmccoy
Modified:
4 years, 7 months ago
Reviewers:
mmccoy1, dgozman, paulirish
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Device frames setting shouldn't be enabled by default BUG=605057 Committed: https://crrev.com/fe8f8a7126f10ff5206c78f3825777a027ac70ed Cr-Commit-Position: refs/heads/master@{#390162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mmccoy1
Ensure deviceFrames setting is not enabled by default.
4 years, 7 months ago (2016-04-27 15:36:17 UTC) #2
dgozman
lgtm. Thanks!
4 years, 7 months ago (2016-04-27 18:43:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929543002/1
4 years, 7 months ago (2016-04-27 18:47:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 20:05:45 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe8f8a7126f10ff5206c78f3825777a027ac70ed
Cr-Commit-Position: refs/heads/master@{#390162}

Powered by Google App Engine
This is Rietveld 408576698