third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js - Issue 1929543002: [DevTools] Device frames setting shouldn't be enabled by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

Issue 1929543002: [DevTools] Device frames setting shouldn't be enabled by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

index 6479e8ed1424b60b9260d6d577d419a5449adec6..662a0588dbd084524355d1cb87adda02a0c5eeb5 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

@@ -45,7 +45,7 @@ WebInspector.DeviceModeModel = function(updateCallback)

this._deviceScaleFactorSetting = WebInspector.settings.createSetting("emulation.deviceScaleFactor", 0);

this._deviceScaleFactorSetting.addChangeListener(this._deviceScaleFactorSettingChanged, this);

- this._deviceOutlineSetting = WebInspector.settings.createSetting("emulation.deviceOutline", true);

+ this._deviceOutlineSetting = WebInspector.settings.createSetting("emulation.deviceOutline", false);

this._deviceOutlineSetting.addChangeListener(this._deviceOutlineSettingChanged, this);

/** @type {!WebInspector.DeviceModeModel.Type} */

« no previous file with comments | « no previous file | no next file » | no next file with comments »